Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:add placement props to popover component #849

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fitrahmunir
Copy link

Checklist

  • Fix linting errors
  • Tests have been added / updated (or snapshots)

Change information

Fix:#839
adding placement="bottomStart" to Popover component on the docs page so the popover-item stay inside the screen

before:

Screen Shot 2023-10-30 at 4 12 35 PM

after:

Screen Shot 2023-10-30 at 4 11 26 PM

@netlify
Copy link

netlify bot commented Oct 30, 2023

Deploy Preview for geist-ui ready!

Name Link
🔨 Latest commit 5332d7d
🔍 Latest deploy log https://app.netlify.com/sites/geist-ui/deploys/653f66ccf5d59f000898b9be
😎 Deploy Preview https://deploy-preview-849--geist-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@fitrahmunir fitrahmunir marked this pull request as ready for review October 30, 2023 08:20
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9e5ceed) 98.85% compared to head (5332d7d) 98.85%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #849   +/-   ##
=======================================
  Coverage   98.85%   98.85%           
=======================================
  Files         198      198           
  Lines        3046     3046           
  Branches      668      668           
=======================================
  Hits         3011     3011           
  Misses         34       34           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant