Improve SitesNeighbourhoods selector #887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lexiwitch
commented
Jan 19, 2022
lexiwitch
commented
Jan 19, 2022
lexiwitch
force-pushed
the
885_sites_neighbourhoods_selector
branch
from
a254c82 to
479b2b4
Compare
lexiwitch
changed the title
kimadactyl
reviewed
Jan 25, 2022
kimadactyl
reviewed
Jan 25, 2022
kimadactyl
reviewed
Jan 25, 2022
kimadactyl
reviewed
Jan 25, 2022
kimadactyl
changed the title
|
Is this loading neighbourhoods via ajax? |
kimadactyl
requested changes
Jan 26, 2022
There was a problem hiding this comment.
- Make fuzzy search type input work on new selects
- All selects currently set to Abbey, Leics
- Make delete link just a link and tidy up UX a lil. i would put all of the inputs together in a fieldset
- Think we need to do something to make the site save buttons look bigger / more important than the secondary neighbourhoods buttons
… creation. So it is intended to be scrapped for another solution
…oods (update fails due to it still passing the neighbourhood_ids parameter l o l. so it is useless. Also probably singlehandedly the most disgusting code ive written lmaoo
… is 99% ready lol
… cocoon (does not work); Rename button
- Memoize parent_name in Neighbourhoods table - Add that to the Neighbourhoods datatables - Add try/catch block to datatable.js to stop errors appearing on pages that do not contain datatables - Remove filtering of primary id from options_for_sites_neighbourhoods - Correct Sites behaviours file to: - Properly add select2 to sites neighbourhoods relational inputs - Remove primary neighbourhood from form field input - Ensure primary neighbourhood selection uses select2 - Properly render SitesNeighbourhoods relation input form template
lexiwitch
force-pushed
the
885_sites_neighbourhoods_selector
branch
from
7fe7236 to
114896d
Compare
|
Rebased on main |
kimadactyl
requested changes
Feb 1, 2022
Done :)
hmm it is not broken for me, it just doesn't display as a select2 element for whatever reason. Moved it to a |
kimadactyl
requested changes
Feb 1, 2022
There was a problem hiding this comment.
Suggested controller tests:
- Create new site with primary neighbourhood only saves. Ditto for edit/update
- Create new site with both primary and secondary neighbourhood saves. Ditto for edit/update.
- Create new site with primary neighbourhood == secondary neighbourhood just saves the primary neighbourhood. Ditto for edit/update
- Same as above but with a few secondary neighbourhoods
- Primary neighbourhood is mandatory (might exist already)
|
Merged, controller tests created as another ticket |
ivankocienski
pushed a commit
to ivankocienski/PlaceCal
that referenced
this pull request
Feb 2, 2022
* Add select2 to primary neighbourhoods form * Add select2 + cocoon to secondary neighbourhoods form * Memoize parent_name field in Neighbourhoods * Give neighbourhoods more context * Add try/catch block to datatable.js to stop errors appearing on pages that do not contain datatables * Remove filtering of primary id from options_for_sites_neighbourhoods * Correct Sites behaviours file to remove primary neighbourhood from form field input * Fix CSS on Cocoon * Buttons: Red. Descriptions: Added Co-authored-by: Dr Kim Foale <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves Secondary Neighbourhood selection in Sites Admin view
Fixes #885