Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove ref to deleted asset #2658

Merged
merged 1 commit into from
Dec 11, 2024
Merged

fix: Remove ref to deleted asset #2658

merged 1 commit into from
Dec 11, 2024

Conversation

kimadactyl
Copy link
Member

@kimadactyl kimadactyl commented Dec 10, 2024

No idea how this slipped through but this test failing. Note the whole collections system needs removing but this gets CI passing again.

 Error:
CollectionsControllerTest#test_should_show_collection:
ActionView::Template::Error: The asset "2017/12/placecal_winter2017.pdf" is not present in the asset pipeline.

    app/views/collections/show.html.erb:25
    test/controllers/collections_controller_test.rb:12:in `block in <class:CollectionsControllerTest>'

663 tests, 1914 assertions, 0 failures, 1 errors, 0 skips

Huly®: PC-2665

Copy link
Collaborator

@lenikadali lenikadali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Note the whole collections system needs removing but this gets CI passing again.

Interesting. Maybe have an issue where this is tracked (so that we don't forget 😅)

@kimadactyl kimadactyl merged commit 5dacf1c into main Dec 11, 2024
2 checks passed
@kimadactyl kimadactyl deleted the hotfix-missing-asset branch December 11, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants