feat: Add Instagram to API endpoint #2655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimadactyl
commented
Dec 8, 2024
katjam
reviewed
Dec 8, 2024
| @@ -288,6 +288,10 @@ def twitter_url | |||
| "https://twitter.com/#{twitter_handle}" if twitter_handle.present? | |||
| end | |||
|
|
|||
| def instagram_url | |||
| "https://instagram.com/#{instagram_handle}" if instagram_handle.present? | |||
There was a problem hiding this comment.
Couldn't immediately see where the instagram_handle is coming from - but appears it was already part of the model. Was it previously not being rendered as a link?
katjam
approved these changes
Dec 8, 2024
|
confirmed working on staging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows access to instagram field on the GraphQL endpoint
Checklist:
Resolves #2654
Description
Motivation and Context
Instagram is one of the most crucial communications platforms for groups.
Type of change
How Has This Been Tested?
I have tested the endpoints in Bruno and added in an extra test.
Huly®: PC-2662