Chore: tests covering image upload problems #1458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erbridge
reviewed
Sep 14, 2022
There was a problem hiding this comment.
There are a couple of changes in here that I'm not sure I understand why they're here (and therefore why they've changed). I suggest pulling them out into their own PRs instead.
The tests themselves look good to me.
Also. There is no such thing as a bad cat picture, how dare you?!
ivan-kocienski-gfsc
force-pushed
the
ik-1428-image-upload-help
branch
from
e958d23 to
5eb16fe
Compare
- verify the error box is present when problems exist - verify the image field has feedback text Pages covered: - site: new, edit - partner: new, edit - article: new, edit - user: new, edit, profile
erbridge
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1428
Pages covered: