Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor conditional rendering for primary neighbourhood in site admin #1426

Merged
merged 5 commits into from
Aug 3, 2022
Merged

Refactor conditional rendering for primary neighbourhood in site admin #1426

merged 5 commits into from
Aug 3, 2022

Conversation

aaaaargZombies
Copy link
Contributor

@aaaaargZombies aaaaargZombies commented Aug 2, 2022 •
edited by huly-for-github bot
Loading

fixes #1423

Before

  • A class was conditionally added to form fields.
  • If this class appeared on the front end the element would be deleted via JS.

After

  • Only render needed form fields.
  • Add test to ensure this is the case.

@github-actions github-actions bot added chore patch Bump version 0.0.X labels Aug 2, 2022
@aaaaargZombies aaaaargZombies changed the title 1423 behaviors.site.js refactor add conditional rendering to fields in sites admin Aug 2, 2022
@aaaaargZombies aaaaargZombies marked this pull request as ready for review August 2, 2022 16:17
@kimadactyl kimadactyl changed the title add conditional rendering to fields in sites admin Add conditional rendering for primary neighbourhood in site admin Aug 3, 2022
@kimadactyl kimadactyl changed the title Add conditional rendering for primary neighbourhood in site admin Refactor conditional rendering for primary neighbourhood in site admin Aug 3, 2022
@kimadactyl kimadactyl merged commit 5f7d211 into main Aug 3, 2022
@kimadactyl kimadactyl deleted the 1423-replace-behaviors.site.js branch August 3, 2022 09:24
@kimadactyl
Copy link
Member

Hard to validate a negative but all sites forms seem working on staging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimadactyl kimadactyl kimadactyl approved these changes

Assignees
No one assigned
Labels
patch Bump version 0.0.X
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace behaviors.site.js
2 participants
@aaaaargZombies @kimadactyl