-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V1 parasites #49
base: 0.6-parasites
Are you sure you want to change the base?
V1 parasites #49
Conversation
Andrew has said this before that each plugin has to be separate. That's why it's (v0.6) listed in the plugin library as two separate entries that you have to build yourself and not part of one's logged in account - ie Rack would tell you if there's an update - one has to do it manually. BTW you've left out the entry to read the reverse value from json southpole-vcvrack/src/Smoke.cpp Lines 134 to 137 in 1e3ec81
|
@SteveRussell33, I believe you are incorrect. The plugin "slug" manifest attribute creates the uniqueness of the plugin. The plugin "name" attribute is used to label your plugin in the plugin library. The "brand" attribute is not used in the library. It is used by the plugin itself as a prefix to the module name when you call the right-click menu. My concern is whether the library build system understands git enough to switch to a different branch based on a commit hash which I think it isn't. To be on the safe side, when the time comes, we will probably need to push parasites to a different repo. |
I edited my post, so it seemed there was some miscommunication - no worries. I tested both and all models appear under Southpole in the module browser. The missing code needs to be added otherwise it'll break patches. |
Oh - looks like our responses crossed the wire 😄. What missing code needs to be added? The slugs of all plugins and modules are compatible and I've tested the builds with old 0.6 patches. |
Read my first post - I had edited it (again!) to include the code that's missing. |
Derp during migration. Thanks to @SteveRussell33 for pointing this out.
Good catch! Fixed. I truly appreciate having another pair of eyes going through so much reworked code. Thanks! |
No problem, glad to help! |
Dont know if is the correct place, but i experience a super low output volume of texture synth on parasites, even with the blend knob all the way down... |
This PR ports parasites to Rack API V1. I'm not sure if the VCV plugin manager is able to deal with two separate plugins under a single repo, so we might need to push parasites into a new repo.