Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename python bindings import library for Windows #1165

Merged
merged 2 commits into from
Oct 20, 2022
Merged

Rename python bindings import library for Windows #1165

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92364d4
Rename python bindings import library for Windows
j-rivero Sep 20, 2022
393f78a
Merge branch 'sdf13' into jrivero/fix_windows_bindings
scpeters Oct 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions python/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,12 @@ target_compile_definitions(${BINDINGS_MODULE_NAME} PRIVATE

set_target_properties(${BINDINGS_MODULE_NAME} PROPERTIES
OUTPUT_NAME "sdformat${PROJECT_VERSION_MAJOR}")
# Deal with naming collision on Windows. It is caused by the both the import
# library of sdformat library and the import library of the pybind11 bindings
# library are called sdformat13.lib.
# See https://github.com/gazebosim/sdformat/issues/1150
set_target_properties(${BINDINGS_MODULE_NAME} PROPERTIES
ARCHIVE_OUTPUT_NAME "python_sdformat${PROJECT_VERSION_MAJOR}")

configure_build_install_location(${BINDINGS_MODULE_NAME})

Expand Down