Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade spdlog version for bazel build to 1.12.0 #159

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

shameekganguly
Copy link
Contributor

🦟 Bug fix

Summary

Spdlog 1.14.1 on bazel central registry will need bazel 7.2.1 to build. I'm downgrading to 1.12.0 to allow clients that are still on bazel 7.0.0 to depend on gz-utils.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@mjcarroll mjcarroll merged commit 9450d4f into gz-utils3 Nov 14, 2024
15 checks passed
@mjcarroll mjcarroll deleted the shameek/spdlog_version branch November 14, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants