Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed repeated installation instructions #160

Merged
merged 3 commits into from
Aug 15, 2020

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Aug 13, 2020

This PR is related with this issue gazebosim/docs#14

Moved install instructions to the tutorials folder.

Signed-off-by: ahcorde [email protected]

@ahcorde ahcorde added the documentation Improvements or additions to documentation label Aug 13, 2020
@ahcorde ahcorde requested a review from chapulina August 13, 2020 10:17
@ahcorde ahcorde self-assigned this Aug 13, 2020
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Aug 13, 2020
@codecov
Copy link

codecov bot commented Aug 13, 2020

Codecov Report

Merging #160 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #160   +/-   ##
=======================================
  Coverage   83.97%   83.97%           
=======================================
  Files          49       49           
  Lines        4725     4725           
=======================================
  Hits         3968     3968           
  Misses        757      757           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d72d63e...96d2087. Read the comment docs.

Copy link
Collaborator

@caguero caguero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

ahcorde and others added 2 commits August 14, 2020 10:23
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina merged commit 56b5047 into master Aug 15, 2020
@chapulina chapulina deleted the ahcorde/docs/installation branch August 15, 2020 01:06

```
sudo apt-get update
sudo apt-get install libignition-transport9-dev
$ sudo apt install libignition-transport<#>-dev

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change don't seems to reflect in installation tutorial like I wondered that should happen.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that's a good point. The Ignition Transport 9.0 documents shouldn't have been uploaded yet because that version hasn't been released. I ticketed an issue here: #162

These tutorial updates should also be made to the Blueprint and Citadel branches (CC @ahcorde )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation 🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants