-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support setting max contacts in dart's bullet collision detector #593
base: gz-physics6
Are you sure you want to change the base?
Conversation
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## gz-physics6 #593 +/- ##
===============================================
- Coverage 78.59% 78.54% -0.06%
===============================================
Files 140 140
Lines 7654 7705 +51
===============================================
+ Hits 6016 6052 +36
- Misses 1638 1653 +15 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
@azeey to review |
Signed-off-by: Ian Chen <[email protected]>
🎉 New feature
depends on #584
Summary
This PR extends dart's bullet collision detector to support the max contact collision pair feature.
This is a follow-up to #582 which added this feature for dart's ode collision detector.
Changes:
GzCollisionDetector
a class for limiting max contact points in dartsim: 4da0d6fGzBulletCollisionDetector
class for extending the max contact feature to dart's bullet collision detector: 4da0d6fTest it
Updated test in
simulation_features.c
to test the max contact feature with dart's bullet collision detectorChecklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.