Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
ignition
togz
gazebo-tooling/release-tools#711Summary
Here's a migration for the QML files which removes the duplicated ones. The trick is:
include/gz/gui/qml/qmldir_deprecated
adds support for theignition.gui
deprecated module, so downstream QML files callingimport ignition.gui 1.0
still workqmldir
andqmldir_deprecated
make sure that bothIgn
andGz
components are available even when importing eitherignition.gui
orgz.gui
.Test it
gz_components
example - this shows that bothIgnSpinBox
andGzSpinBox
work withimport gz.gui 1.0
import ignition.gui 1.0
and check that this works tooChecklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸