Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GCC warnings #433

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Fix GCC warnings #433

merged 1 commit into from
Aug 7, 2024

Conversation

arjo129
Copy link

@arjo129 arjo129 commented Aug 7, 2024

🦟 Bug fix

Summary

Fix gcc warnings in a few places where GCC was complaining about iterating over values instead of reference.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Fix gcc warnings in a few places where GCC was complaining about
iterating over values intead of reference.

Signed-off-by: Arjo Chakravarty <[email protected]>
@arjo129 arjo129 requested a review from nkoenig as a code owner August 7, 2024 06:58
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Aug 7, 2024
@azeey azeey merged commit a8a731a into ign-fuel-tools7 Aug 7, 2024
11 checks passed
@azeey azeey deleted the arjo/fix/gcc_warnings branch August 7, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants