-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Ubuntu 24.04 in Github Actions CI workflow #427
Conversation
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
add a .github/ci/dependencies.yaml to build gz-* dependencies from source
I've attempted to test this branch against gazebosim/gz-cmake#436 in #428. The workflow passes, although there still seems like a problem with the codecov upload |
I've merged gazebosim/gz-cmake#436 and am rebuilding the nightly debs |
I reran the workflow, and it passes, but codecov fails to upload with the following error:
also, merging gazebosim/gz-cmake#436 broke the Ionic workflows that are still using Jammy for coverage (see gazebosim/gz-utils#133) |
reverted in gazebosim/gz-cmake#441 |
Signed-off-by: Addisu Z. Taddese <[email protected]>
I've disabled codecov for now in 8933a58. It looks like we never enabled it for Harmonic either. |
.github/workflows/ci.yml
Outdated
runs-on: ubuntu-latest | ||
name: Ubuntu Jammy CI | ||
name: Ubuntu Noble CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
most of the other packages have added Noble CI alongside Jammy. Should we be disabling that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we don't have codecov working in Noble, perhaps we should leave Jammy in for now. Otherwise, I don't think there's a need to keep Jammy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added jammy back in 85e4178 with codecov enabled.
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
This also enables codecov and linters.
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.