Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ignition #364

Merged
merged 6 commits into from
Aug 30, 2023
Merged

Remove ignition #364

merged 6 commits into from
Aug 30, 2023

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Jul 28, 2023

🎉 New feature

Removes ignition

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Nate Koenig <[email protected]>
@nkoenig nkoenig marked this pull request as draft July 28, 2023 04:07
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Jul 28, 2023
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
@nkoenig nkoenig marked this pull request as ready for review August 2, 2023 12:41
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #364 (76a02d5) into gz-fuel-tools9 (8cf06e1) will decrease coverage by 0.12%.
The diff coverage is 100.00%.

❗ Current head 76a02d5 differs from pull request most recent head c72939f. Consider uploading reports for the commit c72939f to get more accurate results

@@                Coverage Diff                 @@
##           gz-fuel-tools9     #364      +/-   ##
==================================================
- Coverage           75.32%   75.20%   -0.12%     
==================================================
  Files                  20       20              
  Lines                2910     2892      -18     
==================================================
- Hits                 2192     2175      -17     
+ Misses                718      717       -1     
Files Changed Coverage Δ
src/FuelClient.cc 68.51% <ø> (-0.36%) ⬇️
src/ClientConfig.cc 81.70% <100.00%> (-0.39%) ⬇️

@azeey azeey added the beta Targeting beta release of upcoming collection label Aug 23, 2023
@iche033 iche033 changed the base branch from main to gz-fuel-tools9 August 30, 2023 00:48
@nkoenig
Copy link
Contributor Author

nkoenig commented Aug 30, 2023

@osrf-jenkins run tests.

@nkoenig nkoenig merged commit 44182da into gz-fuel-tools9 Aug 30, 2023
8 checks passed
@nkoenig nkoenig deleted the nkoeing/remove-ign branch August 30, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection 🎵 harmonic Gazebo Harmonic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants