Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix triangulation with CDT and update migration guide #623

Merged
merged 3 commits into from
Aug 15, 2024

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Aug 15, 2024

🦟 Bug fix

Summary

Changes:

  • Fixes triangle direction. The triangles returned from CDT are counter-clockwise, so convert them to clockwise in submesh.
  • Fixes style, lint issues
  • Updated migration guide.

I have not moved CDT to its own vendor subdir yet. I just added a README.md with url and commit instead, similar to VHACD.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@iche033 iche033 requested a review from marcoag as a code owner August 15, 2024 20:07
@iche033 iche033 mentioned this pull request Aug 15, 2024
@scpeters
Copy link
Member

I've added a test in a PR targeting this branch: #624

@iche033 iche033 merged commit 39c6470 into mjcarroll/cdt Aug 15, 2024
6 checks passed
@iche033 iche033 deleted the iche033/cdt branch August 15, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants