Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds bvhAnimation test for assimp and collada loaders. #426

Closed
wants to merge 2 commits into from

Conversation

onurtore
Copy link
Contributor

@onurtore onurtore commented Aug 18, 2022

🦟 Bug fix

Fixes #393

Summary

Adds new tests for adding bvhAnimation to skeleton loaded through collada and assimp loaders.

Note to reviewer: This new test will fails the assimpLoader as expected. There are already open PRs focusing on this problem.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Onur Berk Tore <[email protected]>
@onurtore
Copy link
Contributor Author

onurtore commented Aug 18, 2022

Note to reviewer: This new test will fails the assimpLoader as expected. There are already open PRs focusing on this problem.

@chapulina chapulina added tests Broken or missing tests / testing infra graphics Graphics component labels Aug 26, 2022
@mjcarroll
Copy link
Contributor

Note to reviewer: This new test will fails the assimpLoader as expected. There are already open PRs focusing on this problem.

Is this addressed in #425? This is still marked as draft.

@onurtore
Copy link
Contributor Author

onurtore commented Oct 4, 2022

Note to reviewer: This new test will fails the assimpLoader as expected. There are already open PRs focusing on this problem.

Is this addressed in #425? This is still marked as draft.

I am closing this PR and move the code into #425.

@onurtore onurtore closed this Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
graphics Graphics component tests Broken or missing tests / testing infra
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants