Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce priority of Bazel vs CMake #18

Merged
merged 1 commit into from
Jul 21, 2021
Merged

Reduce priority of Bazel vs CMake #18

merged 1 commit into from
Jul 21, 2021

Conversation

mjcarroll
Copy link
Contributor

Fixes gazebosim/gz-bazel#35

In projects with both BUILD.bazel and CMakeLists.txt, both colcon package plugin extensions have the same priority. This causes multiple matches and then colcon will exclude it from the build.

For example:

[0.316s] WARNING:colcon.colcon_core.package_identification:No valid Build content
[0.318s] WARNING:colcon.colcon_core.package_identification:_identify(src/ign-math) has multiple matches and therefore is being ignored: bazel, cmake

This PR lowers the bazel priority so that CMake will "win" in these cases. This can always be overridden via colcon's metadata colcon.pkg files.

@mjcarroll
Reduce priority of Bazel vs CMake
618b376 
Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll
Copy link
Contributor Author

@Theosakamg friendly ping.

@Theosakamg Theosakamg merged commit 20422db into master Jul 21, 2021
@delete-merged-branch delete-merged-branch bot deleted the reduce_priority branch July 21, 2021 14:32
@scpeters scpeters mentioned this pull request Oct 18, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Theosakamg Theosakamg Theosakamg approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUILD.bazel files cause package identification problems
2 participants
@mjcarroll @Theosakamg