-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP upgrade to leptos-0.7 #38
Draft
stefanboere
wants to merge
10
commits into
gaucho-labs:main
Choose a base branch
from
stefanboere:feature/leptos-0.7-upgrade
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
WIP upgrade to leptos-0.7 #38
stefanboere
wants to merge
10
commits into
gaucho-labs:main
from
stefanboere:feature/leptos-0.7-upgrade
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes - Changed Rc<RefCell<..>> to Arc<Mutex<..>> everywhere to get Sync + Send - Added many Send + Sync constraints - Removed default_options from QueryOptions since not supported in Resource any more - Switched to serde_json and serde over miniserde because leptos has a dependency on serde_json already anyway - Undo async trait removal in 'WIP upgrade to leptos-0.7'; It is needed to use this type as trait objects - Removed gloo_timers::future::sleep and used futures::future::pending instead as the future returned by gloo_timers::future::sleep is not Sync Status - start-axum compiles but keeps saying 'Loading...' unless you do prefetch first - start-csr is still todo - ResourceOption::Local option is still todo - I don't know yet how to convert this to 0.7 ``` if resource.loading().get_untracked() && !HydrationCtx::is_hydrating() && query.with_state(|state| matches!(state, QueryState::Created)) { query.execute() } ```
- Use signals to manually interupt the pending future in initial query generator - New execute method that can run while hydrating (uses resource and effect)
I tried to do as much as possible, but running into a few difficult parts where I don't really know how to proceed. See the comments above. So for now I'll stop working on this. And I don't expect to be able to finish this in the future. But I'll leave this PR open so hopefully someone else can give it a try also :). What works:
What doesn't work (see also comment above)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Open issues:
Solved but not sure if solved correctly
Any help on these open points would be appreciated :).