Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/improvements and bugfixes #14

Merged

Conversation

sinadarbouy
Copy link
Contributor

Description:

This feature branch was initially developed to add Pod Disruption Budgets (PDB) and readiness checks. During this process, some challenges were encountered. To address these and further enhance the helm chart, this PR includes a series of improvements and bug fixes:

Features

  1. Pod Disruption Budgets:
    Added Pod Disruption Budgets to maintain application availability during voluntary disruptions.
  2. Readiness Probe:
    Introduced a readinessProbe to enhance the deployment's resilience and ensure only healthy pods receive traffic.
  3. Gatewayd Configuration gatewayd.yaml:
    Added a gatewayd.yaml ConfigMap to allow users to overwrite the gatewayd.yaml file.
    This enables updating the client endpoint and other necessary parameters for better management.
    Updated configuration for gatewayd to allow updating the client endpoint and other necessary parameters for better management.
  4. README Updates:
    Documented the addition of Pod Disruption Budgets.
    Updated the gatewayd configuration section to reflect the recent changes.

Bugfix or Improvement

  1. Update App Version:
    Updated appVersion in chart.yaml to the latest version.

  2. Plugin Install Command:
    Added a command to install plugins

If I understand correctly, we need to run the plugin install command before the gatewayd run command to get binaries for the plugins.

Refactoring:

  1. Configuration Management:
    Moved multi-line string configurations to a dedicated files folder to simplify linting and management of configuration files.
  2. ConfigMap Renaming:
    Renamed gatewayd-gatewayd-plugin-config ConfigMap to remove redundancy, simplifying the name to gatewayd-plugin-config.

@sinadarbouy sinadarbouy marked this pull request as ready for review June 23, 2024 19:03
mostafa

This comment was marked as resolved.

fixed PodDisruptionBudget api version

fixed podDisruptionBudget README
- set default value
- add refactor Descriptions
set example of gatewayd_plugins

added gatewaydConfig to ReadMe

set default gatewaydConfig to false

Move the content configuration from values into files

update deployment
- add install plugin options
- fix volumeMounts when both of gatewaydConfig and gatewaydPluginsConfig enabled
@sinadarbouy sinadarbouy force-pushed the feature/improvements-and-bugfixes branch from a45f4f9 to a021f29 Compare June 23, 2024 19:24
@mostafa mostafa merged commit 6984db1 into gatewayd-io:main Jun 23, 2024
1 check passed
@mostafa
Copy link
Member

mostafa commented Jun 23, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants