Skip to content

Commit

Permalink
Fix MR comments
Browse files Browse the repository at this point in the history
  • Loading branch information
hamedsalim1999 authored Apr 17, 2024
1 parent cbf0a29 commit 0f64e16
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 14 deletions.
10 changes: 4 additions & 6 deletions .github/workflows/helm-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,17 +11,15 @@ on:
- main

jobs:
example:
name: Basic test by Minikube
test:
name: Basic chart test using Minikube
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- name: Start minikube
uses: medyagh/setup-minikube@master
- name: Try the cluster !
- name: Test whether the cluster is running
run: kubectl get pods -A
- name: Checkout code
uses: actions/checkout@v3
- name: Install PostgreSQL
run: helm install psql oci://registry-1.docker.io/bitnamicharts/postgresql --set global.postgresql.auth.postgresPassword=postgres
- name: Check deployment status
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ The following table lists the configurable parameters of the GatewayD Helm chart

## Usage

Modify the values.yaml file to customize the deployment according to your requirements. You can override any default values as needed.
Modify the [values.yaml](values.yaml) file to customize the deployment according to your requirements. You can override any default values as needed.

## Contributing

Expand Down
7 changes: 0 additions & 7 deletions values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -92,9 +92,6 @@ gatewaydPluginsConfig:
enabled: false
content: |
verificationPolicy: "passdown"
compatibilityPolicy: "strict"
acceptancePolicy: "accept"
terminationPolicy: "stop"
enableMetricsMerger: True
metricsMergerPeriod: 5s
healthCheckPeriod: 5s
Expand All @@ -109,10 +106,6 @@ gatewaydPluginsConfig:
args: ["--log-level", "debug"]
env:
- MAGIC_COOKIE_KEY=GATEWAYD_PLUGIN
- MAGIC_COOKIE_VALUE=5712b87aa5d7e9f9e9ab643e6603181c5b796015cb1c09d6f5ada882bf2a1872
- REDIS_URL=redis://localhost:6379/0
- EXPIRY=1h
- METRICS_ENABLED=True
- METRICS_UNIX_DOMAIN_SOCKET=/tmp/gatewayd-plugin-cache.sock
- METRICS_PATH=/metrics
Expand Down

0 comments on commit 0f64e16

Please sign in to comment.