Use the result of notification hooks #616
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket(s)
Closes #397.
Related to #468.
Description
Revised version:
Previously, signals emitted by notification hooks were discarded. This PR changes that behavior by ensuring all actions are executed based on the result of all the hooks (including the notification hooks). Currently, running these actions has no immediate impact, as the results are still mostly discarded. However, once new Signals, Actions, and Policies are implemented (see #468 and gatewayd-io/proposals#5), these results will be utilized effectively.
Related PRs
N/A
Development Checklist
make gen-docs
command.Legal Checklist