Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the result of notification hooks #616

Merged
merged 3 commits into from
Oct 8, 2024
Merged

Conversation

mostafa
Copy link
Member

@mostafa mostafa commented Oct 7, 2024

Ticket(s)

Closes #397.
Related to #468.

Description

Revised version:

Previously, signals emitted by notification hooks were discarded. This PR changes that behavior by ensuring all actions are executed based on the result of all the hooks (including the notification hooks). Currently, running these actions has no immediate impact, as the results are still mostly discarded. However, once new Signals, Actions, and Policies are implemented (see #468 and gatewayd-io/proposals#5), these results will be utilized effectively.

Related PRs

N/A

Development Checklist

  • I have added a descriptive title to this PR.
  • I have squashed related commits together.
  • I have rebased my branch on top of the latest main branch.
  • I have performed a self-review of my own code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added docstring(s) to my code.
  • I have made corresponding changes to the documentation (docs).
  • I have updated docs using make gen-docs command.
  • I have added tests for my changes.
  • I have signed all the commits.

Legal Checklist

@mostafa mostafa self-assigned this Oct 7, 2024
Copy link

github-actions bot commented Oct 7, 2024

Overview

Image reference ghcr.io/gatewayd-io/gatewayd:dc5759a gatewaydio/gatewayd:latest
- digest bb9330dc9844 c0d87a848696
- tag dc5759a latest
- provenance 9ec6b54
- vulnerabilities critical: 0 high: 0 medium: 0 low: 0 critical: 0 high: 0 medium: 0 low: 0
- platform linux/amd64 linux/amd64
- size 19 MB 17 MB (-2.2 MB)
- packages 136 132 (-4)
Base Image alpine:3
also known as:
3.20
3.20.3
latest
alpine:3.20
also known as:
3
3.20.3
latest
- vulnerabilities critical: 0 high: 0 medium: 0 low: 0 critical: 0 high: 0 medium: 0 low: 0
Packages and Vulnerabilities (5 package changes and 0 vulnerability changes)
  • ➖ 3 packages removed
  • ♾️ 2 packages changed
  • 127 packages unchanged
Changes for packages of type apk (3 changes)
Package Version
ghcr.io/gatewayd-io/gatewayd:dc5759a
Version
gatewaydio/gatewayd:latest
ca-certificates 20240705-r0
openssl 3.3.2-r0
pax-utils 1.3.7-r2
Changes for packages of type golang (2 changes)
Package Version
ghcr.io/gatewayd-io/gatewayd:dc5759a
Version
gatewaydio/gatewayd:latest
♾️ github.com/gatewayd-io/gatewayd (devel) 0.9.8
♾️ stdlib go1.23.2 1.23.1

@mostafa mostafa marked this pull request as ready for review October 7, 2024 19:59
@mostafa mostafa requested a review from sinadarbouy October 7, 2024 19:59
Copy link
Collaborator

@sinadarbouy sinadarbouy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@mostafa mostafa merged commit 69298a8 into main Oct 8, 2024
5 checks passed
@mostafa mostafa deleted the use-result-of-notification-hooks branch October 8, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor notification hooks
2 participants