-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(464): add support for queueing async actions in background #544
Conversation
This is in draft mode because it's tests need gatewayd-io/gatewayd-plugin-sdk#34 to be merged and released and can not build or run tests without it |
@Hamsajj I update the SDK and dependencies and you need to rebase from |
22a4b51
to
47ce29e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done! 👏
I just left a comment about the configuration.
Add log message to see if Redis is enabled for publishing async tasks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Hamsajj Thanks for your awesome contribution! 🙏
I tested it locally and found and fixed a bug and did some minor adjustments.
Ticket(s)
#464
Description
This is an alternative approach to this #519 which does not rely on any third-party library.
Uses Redis Pub/Sub as a backend for queuing async actions (if configured).
It will fall back to the normal goroutine if not configured to use Redis.
A consumer is added to gateway-plugin-sdk, which is used in tests to show how it can be used.
Related PRs
This PR is dependent to this one being merged and released gatewayd-io/gatewayd-plugin-sdk#34