Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests #513

Merged
merged 29 commits into from
Apr 24, 2024
Merged

Add more tests #513

merged 29 commits into from
Apr 24, 2024

Conversation

mostafa
Copy link
Member

@mostafa mostafa commented Apr 21, 2024

Ticket(s)

Closes #430

Description

Add more tests.

Related PRs

N/A

Development Checklist

  • I have added a descriptive title to this PR.
  • I have squashed related commits together.
  • I have rebased my branch on top of the latest main branch.
  • I have performed a self-review of my own code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added docstring(s) to my code.
  • I have made corresponding changes to the documentation (docs).
  • I have updated docs using make gen-docs command.
  • I have added tests for my changes.
  • I have signed all the commits.

Legal Checklist

@mostafa mostafa marked this pull request as draft April 21, 2024 17:27
@mostafa mostafa marked this pull request as ready for review April 24, 2024 19:16
@mostafa mostafa merged commit 11164d0 into main Apr 24, 2024
4 checks passed
@mostafa mostafa deleted the add-more-tests branch April 24, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more tests
1 participant