Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add group name to log #394

Merged
merged 3 commits into from
Dec 26, 2023
Merged

add group name to log #394

merged 3 commits into from
Dec 26, 2023

Conversation

jafar75
Copy link
Contributor

@jafar75 jafar75 commented Dec 25, 2023

Ticket(s)

related to #339

Description

by using some functionalities in zerolog, one can add some custom tags to all log lines. e.g. group=default/test/etc

Related PRs

Development Checklist

  • I have added a descriptive title to this PR.
  • I have squashed related commits together.
  • I have rebased my branch on top of the latest main branch.
  • I have performed a self-review of my own code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added docstring(s) to my code.
  • I have made corresponding changes to the documentation (docs).
  • I have added tests for my changes.
  • I have signed all the commits.

Legal Checklist

@jafar75 jafar75 marked this pull request as ready for review December 26, 2023 00:07
Copy link
Member

@mostafa mostafa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jafar75,

Thanks for your contribution! 🚀

Please consider addressing the comments. 🙏 Also, this log output should be updated in the docs.

cmd/run_test.go Outdated Show resolved Hide resolved
logging/logger.go Outdated Show resolved Hide resolved
@mostafa mostafa linked an issue Dec 26, 2023 that may be closed by this pull request
Copy link
Member

@mostafa mostafa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@mostafa mostafa merged commit 155edc2 into main Dec 26, 2023
4 checks passed
@mostafa mostafa deleted the add-group-name-to-log-lines branch December 26, 2023 13:38
@mostafa mostafa mentioned this pull request Dec 27, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reflect the group name in log lines
2 participants