Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't panic #377

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Don't panic #377

merged 1 commit into from
Dec 4, 2023

Conversation

mostafa
Copy link
Member

@mostafa mostafa commented Dec 4, 2023

Ticket(s)

Description

This PR replaces panics with fatal errors, so that normal errors that are only related to the user don't get reported as exceptions in Sentry.

Related PRs

N/A

Development Checklist

  • I have added a descriptive title to this PR.
  • I have squashed related commits together.
  • I have rebased my branch on top of the latest main branch.
  • I have performed a self-review of my own code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added docstring(s) and type annotations to my code.
  • I have made corresponding changes to the documentation (docs).
  • I have added tests for my changes.

Legal Checklist

@mostafa mostafa linked an issue Dec 4, 2023 that may be closed by this pull request
Remove panics if they are just simple errors #368
Closed
@mostafa mostafa merged commit 99b98b1 into main Dec 4, 2023
2 of 3 checks passed
@mostafa mostafa deleted the refactor-panics branch December 4, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove panics if they are just simple errors
1 participant
@mostafa