Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor getter functions #375

Merged
merged 3 commits into from
Nov 19, 2023
Merged

Refactor getter functions #375

merged 3 commits into from
Nov 19, 2023

Conversation

mostafa
Copy link
Member

@mostafa mostafa commented Nov 19, 2023

Ticket(s)

Description

This PR refactors and replaces getter functions for time.Duration and maps using generics.

Related PRs

N/A

Development Checklist

  • I have added a descriptive title to this PR.
  • I have squashed related commits together.
  • I have rebased my branch on top of the latest main branch.
  • I have performed a self-review of my own code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added docstring(s) and type annotations to my code.
  • I have made corresponding changes to the documentation (docs).
  • I have added tests for my changes.

Legal Checklist

@mostafa mostafa merged commit c01a05d into main Nov 19, 2023
3 checks passed
@mostafa mostafa deleted the refactor-getters branch November 19, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor getter functions for time.Duration into a single reusable function
1 participant