Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a regression in plugin install command #323

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

mostafa
Copy link
Member

@mostafa mostafa commented Sep 18, 2023

Ticket(s)

N/A

Description

I found that the gateway plugin install command to properly install plugins, and fails in the middle. This is a regression I introduced in #310, which I fixed in this PR.

Related PRs

Development Checklist

  • I have added a descriptive title to this PR.
  • I have squashed related commits together.
  • I have rebased my branch on top of the latest main branch.
  • I have performed a self-review of my own code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added docstring(s) and type annotations to my code.
  • I have made corresponding changes to the documentation (docs).
  • I have added tests for my changes.

Legal Checklist

@mostafa mostafa changed the title Fix a regression in plugin install command Fix a regression in plugin install command Sep 18, 2023
@mostafa mostafa merged commit 6f712d1 into main Sep 18, 2023
2 checks passed
@mostafa mostafa deleted the fix-regression-in-plugin-install branch September 18, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant