Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor notification hooks #397

Closed
Tracked by #473
mostafa opened this issue Dec 29, 2023 · 0 comments · Fixed by #616
Closed
Tracked by #473

Refactor notification hooks #397

mostafa opened this issue Dec 29, 2023 · 0 comments · Fixed by #616
Assignees
@mostafa
Labels
enhancement New feature or request
Milestone
v0.9.x

Comments

@mostafa
Copy link
Member

mostafa commented Dec 29, 2023 •
edited
Loading

Currently the result of the notification hooks are ignored. These hooks should be changed to receive the result and take advantage of the Act system. This is part of #468.

Related
@mostafa mostafa added the enhancement New feature or request label Dec 29, 2023
@mostafa mostafa mentioned this issue Dec 29, 2023
Open
@mostafa mostafa added this to the v0.8.x milestone Dec 29, 2023
@mostafa mostafa moved this from ✨ New to 📋 Backlog in GatewayD Core Public Roadmap Dec 30, 2023
@mostafa mostafa mentioned this issue Jan 6, 2024
Open
9 tasks
@mostafa mostafa modified the milestones: v0.8.x, v0.9.x Jan 29, 2024
@mostafa mostafa changed the title Refactor the hook system Refactor notification hooks Mar 3, 2024
@mostafa mostafa mentioned this issue Mar 2, 2024
Open
11 tasks
@mostafa mostafa mentioned this issue May 1, 2024
Open
This was referenced Oct 6, 2024
Merged
Merged
Merged
@mostafa mostafa self-assigned this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mostafa mostafa

Labels
enhancement New feature or request
Projects
GatewayD Core Public Roadmap
Status: 🎉 Done
Milestone
v0.9.x
Development

Successfully merging a pull request may close this issue.

Use the result of notification hooks gatewayd-io/gatewayd
1 participant
@mostafa