Check if the value is nil before putting it into the pool

gatewayd-io · Oct 15, 2023 · f201736 · f201736
1 parent e13389a
commit f201736
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/errors/errors.go b/errors/errors.go
@@ -27,6 +27,7 @@ const (
 	ErrCodeAcceptFailed
 	ErrCodeReadFailed
 	ErrCodePutFailed
+	ErrCodeNilPointer
 	ErrCodeCastFailed
 	ErrCodeHookVerificationFailed
 	ErrCodeHookReturnedError
@@ -96,6 +97,8 @@ var (
 
 	ErrPutFailed = NewGatewayDError(
 		ErrCodePutFailed, "failed to put in pool", nil)
+	ErrNilPointer = NewGatewayDError(
+		ErrCodeNilPointer, "nil pointer", nil)
 
 	ErrCastFailed = NewGatewayDError(
 		ErrCodeCastFailed, "failed to cast", nil)

diff --git a/pool/pool.go b/pool/pool.go
@@ -57,6 +57,12 @@ func (p *Pool) Put(key, value interface{}) *gerr.GatewayDError {
 		span.RecordError(gerr.ErrPoolExhausted)
 		return gerr.ErrPoolExhausted
 	}
+
+	if value == nil {
+		span.RecordError(gerr.ErrNilPointer)
+		return gerr.ErrNilPointer
+	}
+
 	p.pool.Store(key, value)
 	return nil
 }
@@ -80,6 +86,12 @@ func (p *Pool) GetOrPut(key, value interface{}) (interface{}, bool, *gerr.Gatewa
 		span.RecordError(gerr.ErrPoolExhausted)
 		return nil, false, gerr.ErrPoolExhausted
 	}
+
+	if value == nil {
+		span.RecordError(gerr.ErrNilPointer)
+		return nil, false, gerr.ErrNilPointer
+	}
+
 	val, loaded := p.pool.LoadOrStore(key, value)
 	return val, loaded, nil
 }