Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use github.event.pull_request.head.sha for checkout@v4 #1531

Merged
merged 3 commits into from
Dec 23, 2023

Conversation

dgrebb
Copy link
Contributor

@dgrebb dgrebb commented Dec 23, 2023

@garris trying something else for the failing GH actions — I recently updated the checkout action to v4, and see that one of their examples uses head.sha instead of head.ref.

Can we please give this a try?

@dgrebb
Copy link
Contributor Author

dgrebb commented Dec 23, 2023

🙈 Backstop & Docker CI

@garris this badge and the passed Checks on this PR confirm the fix 👍

@garris
Copy link
Owner

garris commented Dec 23, 2023

It works! Amazing! 🌈

@garris
Copy link
Owner

garris commented Dec 23, 2023

Oof -- merge blocker.

image

@garris
Copy link
Owner

garris commented Dec 23, 2023

I can probably brute-force this tomorrow.

@dgrebb
Copy link
Contributor Author

dgrebb commented Dec 23, 2023

@garris I've never seen this GitHub UI before — what's the context? Did it pop up when clicking squash merge?

@dgrebb dgrebb force-pushed the feature/44-github-workflows branch from 6df8979 to 78d21d3 Compare December 23, 2023 07:05
@dgrebb
Copy link
Contributor Author

dgrebb commented Dec 23, 2023

I added actions: write permission to the workflows. Let's see what that does?

@garris garris merged commit 169d7af into garris:master Dec 23, 2023
4 checks passed
@garris
Copy link
Owner

garris commented Dec 23, 2023

Worked!

@dgrebb dgrebb deleted the feature/44-github-workflows branch December 23, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants