Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adds headless ternary to handle 'new', true, and false in a non-… #1511

Merged
merged 1 commit into from
Nov 22, 2023
Merged

fix: adds headless ternary to handle 'new', true, and false in a non-… #1511

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -644,12 +644,13 @@ ignoreHTTPSErrors: true,
headless: <!!!config.debugWindow>
```

You can add more settings (or override the defaults) with the engineOptions property. (properties are merged)
You can add more settings (or override the defaults) with the engineOptions property. (properties are merged). This is where headless mode can also be set to 'new', until "new headless mode" is the default in Puppet/Playwright.

```json
"engineOptions": {
"ignoreHTTPSErrors": false,
"args": ["--no-sandbox", "--disable-setuid-sandbox"],
"headless": "new",
"gotoParameters": { "waitUntil": "networkidle0" },
}
```
Expand Down
2 changes: 1 addition & 1 deletion core/util/runPlaywright.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ module.exports.createPlaywrightBrowser = async function (config) {
const playwrightArgs = Object.assign(
{},
{
headless: !config.debugWindow
headless: config.debugWindow ? false : config?.engineOptions?.headless || true
},
config.engineOptions
);
Expand Down
2 changes: 1 addition & 1 deletion core/util/runPuppet.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ async function processScenarioView (scenario, variantOrScenarioLabelSafe, scenar
{},
{
ignoreHTTPSErrors: true,
headless: !config.debugWindow
headless: config.debugWindow ? false : config?.engineOptions?.headless || true
},
config.engineOptions
);
Expand Down