Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to new CoffeeScript #17

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Update to new CoffeeScript #17

wants to merge 5 commits into from

Conversation

garrett
Copy link
Owner

@garrett garrett commented Jun 4, 2020

  1. Fixed CoffeeScript to compile again, as the new version of CoffeeScript is mainly backwards compatible, but missing a comma caused the source to not compile.
  2. Updated CoffeeScript coding style using lint suggestions.
  3. Recompiled JavaScript from CoffeeScript source.
  4. Updated README to reference just npm and use coffeescript instead of the old coffee-script.

@garrett garrett self-assigned this Jun 4, 2020
@garrett
Copy link
Owner Author

garrett commented Jun 4, 2020

I've updated things a bit in this PR as it seems there is interest in people using magicmockup. We should, at a minimum, make sure it compiles with updated tooling.

@garrett
Copy link
Owner Author

garrett commented Jun 4, 2020 •
edited
Loading

Additionally, jQuery should be updated (in this PR, probably).

And eventually, perhaps, we should port over to using plain JavaScript functions instead of jQuery (in a follow-up PR).

@garrett garrett mentioned this pull request Jun 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@garrett garrett

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@garrett