Skip to content

Commit

Permalink
Fix make deploy-debug (#876)
Browse files Browse the repository at this point in the history
  • Loading branch information
shreyas-s-rao authored Sep 10, 2024
1 parent d3ac301 commit 4fb2b05
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ deploy-dev: $(SKAFFOLD) $(HELM)

.PHONY: deploy-debug
deploy-debug: $(SKAFFOLD) $(HELM)
@VERSION=$(VERSION) GIT_SHA=$(GIT_SHA) $(SKAFFOLD) debug --cleanup=false -m etcd-druid
@VERSION=$(VERSION) GIT_SHA=$(GIT_SHA) $(SKAFFOLD) debug --cleanup=false -m etcd-druid -p debug

.PHONY: undeploy
undeploy: $(SKAFFOLD) $(HELM)
Expand Down
12 changes: 11 additions & 1 deletion skaffold.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ build:
flags:
- -v
ldflags:
- -w
- -X github.com/gardener/etcd-druid/internal/version.Version={{.VERSION}}
- -X github.com/gardener/etcd-druid/internal/version.GitSHA={{.GIT_SHA}}
deploy:
Expand All @@ -31,6 +30,17 @@ deploy:
setValues: # empty `setValues` value is not allowed
foo: bar
profiles:
# Profile to disable druid leader election, to allow debugging without abrupt exits due to failure to renew leader election lease within time.
- name: debug
patches:
- op: add
path: /deploy/helm/releases/0/setValues/replicas
value: 1
- op: add
path: /deploy/helm/releases/0/setValues/controllerManager
value:
leaderElection:
enabled: false
- name: e2e-test
activation:
- env: "DRUID_E2E_TEST=true"
Expand Down

0 comments on commit 4fb2b05

Please sign in to comment.