Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

student feature: Add the ability to report exercises #2600

Merged
merged 6 commits into from
Dec 11, 2022

Conversation

flacial
Copy link
Member

@flacial flacial commented Dec 10, 2022

Related to #2251

Description

This PR adds the ability for the students to report exercise while solving them.

In the exercise solving main page, it'll look like this:

Images image image

Once an exercise is flagged, it'll remain in the list, and it'll appear in the page for managing exercises under /admin/lessons/[lessonId]/exercises. The admin has the option to either unflag it or remove it.

Bugs

  • It doesn't gracefully handle the thrown error when an exercise is already flagged. Will be handled in a subsequent PR.

Extra functional requirements for flagging exercises

  • Students should know that the exercise they're solving has been flagged.
  • If there are multiple reports for the same exercise, it should group them together for easier review.

@vercel
Copy link

vercel bot commented Dec 10, 2022

@flacial is attempting to deploy a commit to the c0d3-prod Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Dec 10, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
c0d3-app ✅ Ready (Inspect) Visit Preview Dec 11, 2022 at 2:17PM (UTC)

@codecov
Copy link

codecov bot commented Dec 10, 2022

Codecov Report

Merging #2600 (a53a919) into master (b105d42) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #2600   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          187       187           
  Lines         3435      3434    -1     
  Branches       938       937    -1     
=========================================
- Hits          3435      3434    -1     
Impacted Files Coverage Δ
components/ExerciseCard/ExerciseCard.tsx 100.00% <ø> (ø)
pages/exercises/[lessonSlug].tsx 100.00% <ø> (ø)
...mponents/ExerciseReportCard/ExerciseReportCard.tsx 100.00% <100.00%> (ø)

@SlyBouhafs
Copy link
Member

SlyBouhafs commented Dec 11, 2022

Wouldn't it be better to make it wide so that it covers all the white space on the right?

flag_exercise

@flacial
Copy link
Member Author

flacial commented Dec 11, 2022

@SlyBouhafs I think gray is better because it's more neutral for the thing it does: returning the user to the previous screen. Red/the current color empathize a CTO, which is misleading.

@flacial
Copy link
Member Author

flacial commented Dec 11, 2022

Wouldn't it be better to make it wide so that it covers all the white space on the right?

flag_exercise

Yeah, good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🦄 Done
Development

Successfully merging this pull request may close these issues.

2 participants