Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show next question button after user answers exercise correctly #2349

Merged
merged 6 commits into from
Sep 26, 2022
Merged

Show next question button after user answers exercise correctly #2349

merged 6 commits into from
Sep 26, 2022

Conversation

bryanjenningz
Copy link
Collaborator

Changes:

  • Add "NEXT QUESTION" button after user successfully answers a question
  • Extract ExerciseCard state as props
  • Rename ExerciseCard props

How to test:

  • Create a DOJO module at /admin/lessons/js0/modules
  • Create a DOJO exercise at /curriculum/js0/mentor
  • Go to the DOJO exercises page at /exercises/js0
  • Click on "SOLVE EXERCISES" button
  • Answer the exercise correctly
  • Verify that the "NEXT QUESTION" button shows up

next-question-400px
next-question-770px
next-question-desktop

This pull request is related to #2253

@vercel
Copy link

vercel bot commented Sep 26, 2022

@bryanjenningz is attempting to deploy a commit to the c0d3-prod Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Sep 26, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
c0d3-app ✅ Ready (Inspect) Visit Preview Sep 26, 2022 at 3:43PM (UTC)

@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

Merging #2349 (3ca645f) into master (b02826a) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #2349   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          181       181           
  Lines         3178      3182    +4     
  Branches       836       840    +4     
=========================================
+ Hits          3178      3182    +4     
Impacted Files Coverage Δ
components/ExerciseCard/ExerciseCard.tsx 100.00% <100.00%> (ø)
pages/exercises/[lessonSlug].tsx 100.00% <100.00%> (ø)

@flacial
Copy link
Member

flacial commented Sep 26, 2022

When there isn't a next exercise, it shows the button and when it's clicked, it goes back to home back:

image

image

This behavior will be handled in a subsequent PR?

@bryanjenningz
Copy link
Collaborator Author

When there isn't a next exercise, it shows the button and when it's clicked, it goes back to home back:

image image

This behavior will be handled in a subsequent PR?

Yes, it will be handled in a subsequent PR.

@bryanjenningz bryanjenningz merged commit 5a6e048 into garageScript:master Sep 26, 2022
@bryanjenningz bryanjenningz deleted the show-next-question-button-after-user-answers-exercise-correctly branch September 26, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants