Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DOJO exercise list responsive #2342

Merged
merged 2 commits into from
Sep 24, 2022
Merged

Make DOJO exercise list responsive #2342

merged 2 commits into from
Sep 24, 2022

Conversation

bryanjenningz
Copy link
Collaborator

@bryanjenningz bryanjenningz commented Sep 24, 2022

This pull request switches the DOJO exercise list styling to use CSS grid instead of Bootstrap rows so that it's responsive to different screen widths.

How to test:

400px wide phone:
exercise-list-400px
600px wide:
exercise-list-600px
1000px wide:
exercise-list-1000px
1200px wide:
exercise-list-1200px
1600px wide:
exercise-list-1600px

This pull request is a part of #2251

@vercel
Copy link

vercel bot commented Sep 24, 2022

@bryanjenningz is attempting to deploy a commit to the c0d3-prod Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Sep 24, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
c0d3-app ✅ Ready (Inspect) Visit Preview Sep 24, 2022 at 5:31PM (UTC)

@SlyBouhafs
Copy link
Member

Looks good! Can we make the Solve exercises button width 100% on 600px and 400px?

@bryanjenningz
Copy link
Collaborator Author

Looks good! Can we make the Solve exercises button width 100% on 600px and 400px?

I changed it so that it's 100% width in the Bootstrap xs and sm widths (i.e. <768px), so this is what it looks like now.

400px wide:
new-width-100-button-400px

600px wide:
new-width-100-button-600px

@bryanjenningz bryanjenningz merged commit 4c87423 into garageScript:master Sep 24, 2022
@bryanjenningz bryanjenningz deleted the make-exercise-list-responsive branch September 24, 2022 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants