Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exercise card to DOJO exercises page #2325

Merged
merged 8 commits into from
Sep 19, 2022
Merged

Add exercise card to DOJO exercises page #2325

merged 8 commits into from
Sep 19, 2022

Conversation

bryanjenningz
Copy link
Collaborator

@bryanjenningz bryanjenningz commented Sep 18, 2022

This pull request doesn't change any user-facing pages, it only changes the DOJO exercises pages (e.g. /exercises/js0) which currently doesn't have any links to it.

This pull request adds the exercise card to the DOJO exercises page. It currently uses mock data on the frontend and doesn't store the user's answers. It will be connected to the backend and real data in a subsequent pull request.

How to test:

  • Go to /exercises/js0
  • Click "SOLVE EXERCISES" button
  • Answer questions, show and hide solutions, click "SKIP" button, click "PREVIOUS" button, click "Exit" button

The newly added "SOLVED EXERCISES" button on the right side of the /exercises/js0 page:
solve-exercises-button

The first exercise:
solve-exercise

The solved second exercise:
solve-exercise-2

This pull request is a part of #2253

@vercel
Copy link

vercel bot commented Sep 18, 2022

@bryanjenningz is attempting to deploy a commit to the c0d3-prod Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Sep 18, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
c0d3-app ✅ Ready (Inspect) Visit Preview Sep 19, 2022 at 6:00AM (UTC)

@codecov
Copy link

codecov bot commented Sep 18, 2022

Codecov Report

Merging #2325 (d5888a0) into master (ee91a31) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #2325   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          180       180           
  Lines         3148      3172   +24     
  Branches       838       847    +9     
=========================================
+ Hits          3148      3172   +24     
Impacted Files Coverage Δ
components/ExerciseCard/ExerciseCard.tsx 100.00% <ø> (ø)
pages/exercises/[lessonSlug].tsx 100.00% <100.00%> (ø)

@flacial
Copy link
Member

flacial commented Sep 18, 2022

More margin (32px not 138px) between the main content and the nav would be nice

image

And more between the content and the heading + button (24px not 112px)

image

@flacial
Copy link
Member

flacial commented Sep 18, 2022

The error is different than the design:

image

Should be:

image

With red border and red text.


Actually, this is related to the previous PR and shouldn't be addressed in this PR.

@flacial
Copy link
Member

flacial commented Sep 18, 2022

Other features such as flagging and the filtering dropdown will be addressed in a subsequent PR?

@bryanjenningz
Copy link
Collaborator Author

Other features such as flagging and the filtering dropdown will be addressed in a subsequent PR?

Yeah, I'm just trying to get the features done in small pull requests so they're easy to review. We can include more stuff in later pull requests.

@bryanjenningz
Copy link
Collaborator Author

The error is different than the design:

image

Should be:

image

With red border and red text.

Actually, this is related to the previous PR and shouldn't be addressed in this PR.

Thanks! Fixed in #2326

@bryanjenningz bryanjenningz merged commit d60042b into garageScript:master Sep 19, 2022
@bryanjenningz bryanjenningz deleted the add-exercise-card-to-dojo-exercises-page branch September 19, 2022 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants