Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exercise preview cards to DOJO exercises page #2281

Merged
merged 11 commits into from
Sep 12, 2022
Merged

Add exercise preview cards to DOJO exercises page #2281

merged 11 commits into from
Sep 12, 2022

Conversation

bryanjenningz
Copy link
Collaborator

@bryanjenningz bryanjenningz commented Sep 11, 2022

This pull request adds a new ExercisePreviewCard component which gets used on the DOJO exercises page.
The exercise preview cards are populated with mock data on the frontend, but this will be removed once the backend returns DOJO exercise preview data.

screenshot

This change doesn't affect any user-facing pages since there are no links to the /exercises/:lessonSlug page right now.

How to test:

  • Go to /exercises/js0
  • Make sure everything looks good

This pull request is a part of #2253.

@vercel
Copy link

vercel bot commented Sep 11, 2022

@bryanjenningz is attempting to deploy a commit to the c0d3-prod Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Sep 11, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
c0d3-app ✅ Ready (Inspect) Visit Preview Sep 12, 2022 at 4:19AM (UTC)

@codecov
Copy link

codecov bot commented Sep 11, 2022

Codecov Report

Merging #2281 (ee742c6) into master (7563379) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #2281   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          177       178    +1     
  Lines         3066      3077   +11     
  Branches       818       823    +5     
=========================================
+ Hits          3066      3077   +11     
Impacted Files Coverage Δ
...onents/ExercisePreviewCard/ExercisePreviewCard.tsx 100.00% <100.00%> (ø)
pages/exercises/[lessonSlug].tsx 100.00% <100.00%> (ø)

@SlyBouhafs
Copy link
Member

The answered state badge looks a bit big, can we make it the same size as the admin badge?

@bryanjenningz
Copy link
Collaborator Author

@SlyBouhafs Thanks for suggestion. I updated the badge size.

@flacial
Copy link
Member

flacial commented Sep 11, 2022

We decided to create a folder for each component. This folder will contain the component itself, its styles, and test file.

When creating new components, refer to #2080

@bryanjenningz
Copy link
Collaborator Author

@flacial Thanks for letting me know. I just changed the code so that the component file and styles file are in the same folder. I tried putting the storybook file in the same folder too but it didn't show up when I ran storybook, so I moved the storybook file back to the storybook folder with all the other storybook files.

@bryanjenningz bryanjenningz merged commit 8c30490 into garageScript:master Sep 12, 2022
@bryanjenningz bryanjenningz deleted the add-exercise-previews-to-dojo-exercises-page branch September 12, 2022 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants