Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up whitespace around references #369

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

ChrisJefferson
Copy link
Contributor

If you go to https://www.gap-system.org/capabilities/groups , and look at the first sentence, you will notice there is no whitespace before every link. This seems to be a consistent problem, across much of the site.

The issue is the use of {%- , which eats whitespace, instead of {%, which leaves it in.

I've tried to make a pass over all links, and look for this issue. I haven't edited some cases (notably inside _includes/ref.html, and some code in index.md), as there there are a series of tags, and the whitespace removal is on purpose.

I will admit I didn't go and check every single line I editted, but I do a bunch of random spot checks, and they either looked the same (as they were at the start of a line), or were improved, and I thought changing all cases in 'natural text' was best, so if future people work by copying existing code, they will be copying the right formatting.

I'm not sure if this was actually done on purpose, or this style of formatting was done automatically and made some text look good, while messing up other text?

Copy link
Member

@wilfwilson wilfwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we could be missing something, but I can't imagine what.

Looks good to me.

@fingolfin fingolfin merged commit 5f407d1 into gap-system:master Nov 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants