Skip to content

Commit

Permalink
Merge pull request #60 from gandersen101/bug-tokenmatcher-match-order
Browse files Browse the repository at this point in the history
Bug tokenmatcher match order
  • Loading branch information
gandersen101 authored May 22, 2021
2 parents 13fced9 + 52bf100 commit c2895f6
Show file tree
Hide file tree
Showing 8 changed files with 235 additions and 240 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
*v0.5.3 Release Notes:*
- *Fixed a "bug" in the `TokenMatcher`. Spaczz expects token matches returned in order of ascending match start, then descending match length. However, spaCy's `Matcher` does not return matches in this order by default. Added a sort in the `TokenMatcher` to ensure this.*


*v0.5.2 Release Notes:*
- *Minor updates to pre-commits and noxfile.*

Expand Down
7 changes: 3 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,12 @@ Fuzzy matching is currently performed with matchers from [RapidFuzz](https://git

Spaczz has been tested on Ubuntu 18.04, MacOS 10.15, and Windows Server 2019.

*v0.5.3 Release Notes:*
- *Fixed a "bug" in the `TokenMatcher`. Spaczz expects token matches returned in order of ascending match start, then descending match length. However, spaCy's `Matcher` does not return matches in this order by default. Added a sort in the `TokenMatcher` to ensure this.*

*v0.5.2 Release Notes:*
- *Minor updates to pre-commits and noxfile.*

*v0.5.1 Release Notes:*
- *Minor updates to allowed dependency versions and CI.*
- *Switched back to using typing types instead of generic types because spaCy v3 uses Pydantic and Pydantic does not support generic types in Python < 3.9. I don't know if this would actually cause any issues but I am playing it safe. Potentially more changes for spaczz to play nicely with Pydantic to follow.*

Please see the [changelog](https://github.com/gandersen101/spaczz/blob/master/CHANGELOG.md) for previous release notes. This will eventually be moved to the [Read the Docs](https://spaczz.readthedocs.io/en/latest/) page.

<h1>Table of Contents<span class="tocSkip"></span></h1>
Expand Down
Loading

0 comments on commit c2895f6

Please sign in to comment.