Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Android and Universal URL Support #18

Merged
merged 10 commits into from
Jun 12, 2024

Conversation

TosinJs
Copy link
Collaborator

@TosinJs TosinJs commented May 14, 2024

Description

Add Android and Universal URL support.

New Video

https://www.loom.com/share/8e0ae6dcdb4d4693aec1f621810de028

https://www.loom.com/share/dcdc2c25d67a4acc9c567b88a7d48f48

Motivation and Context

How Has This Been Tested?

Screen recording (compulsory):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Improvement (general improvements to how code looks/works)

Checklist

  • I have created a branch for this patch/feature.
  • My pull request addresses exactly one patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have tested manually on my deployed review app.
  • My code follows the code style of this project.
  • I have requested and received approval from a peer
  • I have requested and received (initial) approval from the code owner
  • I have completed QA testing
  • I have received final approval from the code owner

Copy link
Contributor

@timigod timigod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should default to iOS - that will be fully backward compatible. Plus, the universal URL will first take the user to the browser & then redirect accordingly, so it's not like it's a great experience.

@TosinJs TosinJs merged commit b2d3b6b into staging Jun 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants