Merge pull request #24 from gandalf-network/staging

Staging -> Prod [ Gandalf Email Trait ]
gandalf-network · Jun 12, 2024 · 8abe582 · 8abe582
2 parents 784ccd8 + f31f3b9
commit 8abe582
Show file tree

Hide file tree

Showing 6 changed files with 33 additions and 9 deletions.
diff --git a/README.md b/README.md
@@ -32,7 +32,16 @@ import Connect from "@gandalf-network/connect";
 const connect = new Connect({
     publicKey: process.env.PUBLIC_KEY, 
     redirectURL: "YOUR_REDIRECT_URL",
-    services: { "NETFLIX": true } // At least one service is required
+    services: 
+    {
+        uber: {
+            traits: ["rating"], // At least one trait or activity is required
+            activities: ["trip"],
+        },
+        gandalf: {
+            traits: ["email"]
+        }
+    } // Only one non "Gandalf" service (e.g "netflix", "instacart") is supported per Connect URL
 })
 ```
 
@@ -43,7 +52,16 @@ const Connect = require("@gandalf-network/connect");
 const connect = new Connect({
     publicKey: process.env.PUBLIC_KEY, 
     redirectURL: "YOUR_REDIRECT_URL",
-    services: { "NETFLIX": true } // At least one service is required
+    services: 
+    {
+        uber: {
+            traits: ["rating"], // At least one trait or activity is required
+            activities: ["trip"],
+        },
+        gandalf: {
+            traits: ["email"]
+        }
+    } // Only one non "Gandalf" service (e.g "uber", "amazon") is supported per Connect URL
 })
 ```
 

diff --git a/examples/example.ts b/examples/example.ts
@@ -8,6 +8,9 @@ const services: InputData = {
         traits: [TraitLabel.Plan],
         activities: [ActivityType.Trip],
     },
+    gandalf: {
+        traits: ["email"]
+    }
 }
 
 async function example() {

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@gandalf-network/connect",
-  "version": "1.0.8",
+  "version": "1.0.9",
   "description": "",
   "main": "dist/index.js",
   "module": "dist/index.mjs",

diff --git a/src/connect.ts b/src/connect.ts
@@ -165,9 +165,9 @@ class Connect {
 
     const keys = Object.keys(input).map((key) => key.toLowerCase());
 
-    if (keys.length > 1) {
+    if (keys.length > 2 || (keys.length === 2 && !keys.includes('gandalf'))) {
       throw new GandalfError(
-        `Only one service is supported per Connect URL`,
+        `Only one non Gandalf service is supported per Connect URL`,
         GandalfErrorCode.InvalidService,
       );
     }
@@ -266,4 +266,4 @@ class Connect {
   }
 }
 
-export default Connect;
+export default Connect;
diff --git a/tests/connect.spec.ts b/tests/connect.spec.ts
@@ -26,6 +26,9 @@ describe("Connect SDK", () => {
       traits: ["rating"],
       activities: ["trip"],
     },
+    gandalf: {
+      traits: ["email"],
+    }
   }
   const stringData = JSON.stringify(services);
 
@@ -206,7 +209,7 @@ describe("Connect SDK", () => {
       });
 
       await expect(connect.generateURL()).rejects.toThrow(
-        "Only one service is supported per Connect URL",
+        "Only one non Gandalf service is supported per Connect URL",
       );
       expect(connect.verificationComplete).toEqual(false);
     });