Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update redorchestra to use correct query port and type #639

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

feat: update redorchestra to use correct query port and type #639

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bf1077a
feat: update redorchestra to use correct query port and type
dgibbs64 Sep 16, 2024
5521d76
Update changelog
dgibbs64 Sep 16, 2024
6ad4a5d
correct changelog formatting
dgibbs64 Sep 28, 2024
21a679f
resolve review
dgibbs64 Sep 28, 2024
14d2712
fix
dgibbs64 Sep 28, 2024
f1f9a98
Merge branch 'master' into redorchestra
dgibbs64 Sep 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## 5.X.Y
* Feat: Replaced `punycode` package usage with `url.domainToASCII` (#630).
* Feat: World of Padman (2007) - Added support (#636)
* Feat: Update redorchestra to use correct query port and type (#639)

## 5.1.3
* Fix: `Deus Ex` using the wrong protocol (#621)
Expand All @@ -23,7 +24,7 @@
## 5.1.1
* Lock dependencies to fix problems with cheerio's `1.0.0` release and update punycode to `2.3.1` to mitigate
a vulnerability (#604)
* Fix the `name` field on Minecraft servers:
* Fix the `name` field on Minecraft servers:
* * running Velocity with multiple layers of color encoding (#595)
* * the top-level text of the description is a string composed of empty characters (#599)
* Fix branding for alt:V Multiplayer (By @xCausxn #600)
Expand Down Expand Up @@ -52,7 +53,7 @@ a vulnerability (#604)
* Farming Simulator 19 (2018) - Added support (By @Vito0912 #531)
* Assetto Corsa - Fixed how `state.numplayers` is set (By @podrivo #538)
* TeamSpeak 2 - Fixed how `state.name` is set (By @podrivo #544)
* Grand Theft Auto: San Andreas OpenMP - Fixed `state.players` returning an empty array (By @Focus04 #547)
* Grand Theft Auto: San Andreas OpenMP - Fixed `state.players` returning an empty array (By @Focus04 #547)
* Perf: Re-write of the `core` class.
* Perf: Remove many if statements from `GameSpy2`.
* Myth of Empires - Added support.
Expand Down Expand Up @@ -85,7 +86,7 @@ a vulnerability (#604)

#### Games
* Almost all games ids have been changed to follow a standard, see [CONTRIBUTING.md#naming](https://github.com/gamedig/node-gamedig/blob/5ae12dd494c927abcbe43352609d9aa34a54753c/CONTRIBUTING.md?plain=1#L27C3-L27C3).
* Removed `minecraftping` (as it was deprecated and the same thing as `minecraft`) and
* Removed `minecraftping` (as it was deprecated and the same thing as `minecraft`) and
`minecraftpe` (deprecated, which is now the same as `mbe` (Minecraft Bedrock Edition)).
* Removed the `games.txt` file, the games definitions are now stored in-code (exported on `games`).

Expand Down Expand Up @@ -117,7 +118,7 @@ a vulnerability (#604)
* Now documented: `address` (defaults to `undefined`) Override the IP address of the server skipping DNS resolution. When set, host will not be resolved, instead address will be connected to. However, some protocols still use host for other reasons e.g. as part of the query.

#### Games
* Removed the players::setNum method, the library will no longer add empty players as
dgibbs64 marked this conversation as resolved.
Show resolved Hide resolved
* Removed the players::setNum method, the library will no longer add empty players as
placeholders in the `players` fields.
* Valve: dont skip players with no name and keep state.raw.players.
* Stabilized field `numplayers`.
Expand Down
16 changes: 2 additions & 14 deletions lib/games.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2363,24 +2363,12 @@ export const games = {
}
},
redorchestra: {
name: 'Red Orchestra',
release_year: 2018,
options: {
port: 7758,
port_query_offset: 1,
protocol: 'unreal2'
}
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't remove this entry, even if it is completely wrong and if it is, we should remove it in a major version.

roo4145: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The GID for the game name should be roo4145, not redorchestra.

name: 'Red Orchestra: Ostfront 41-45',
release_year: 2006,
options: {
port: 7757,
port_query_offset: 10,
protocol: 'gamespy1'
},
extra: {
old_id: 'redorchestraost'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't remove the old id as it breaks backwards compatibility.

port_query_offset: 1,
protocol: 'unreal2'
}
},
redorchestra2: {
Expand Down
Loading