fix: minecraft vanilla top level description text and mixed cases

[CosminPerRam]

Closes #598

[xCausxn]

What if description.text is a value but also has description.extra?

[CosminPerRam]

Yep, maybe we should get rid of those two conditions (last 2 ifs), and just name = description?.text || ' ' + {processExtras(description.extra)}.
I'm not really sure of it as this would be a breaking change (whereas the fix I've done is not unless a server's name is JUST empty spaces (this is also partial as the default name is a empty string)), cause we would be suddenly changing some queries name output.

[CosminPerRam]

The best solution here is to just do what Minecraft is doing internally, but I don't think we have access to that at all nor will they provide that, I'll have to look into it.

[xCausxn]

Well we can just use the second if condition for both cases as we just need to set name to description.text and if description.extra does exist continue to append the text.

I think that would satisfy both cases without being a breaking change.

I did have a working impl for the velocity fix but you got the PR in sooner 😅

[xCausxn]

The best solution here is to just do what Minecraft is doing internally, but I don't think we have access to that at all nor will they provide that, I'll have to look into it.

Apologies about the formatting, but as a reference I just did an example in this branch based on the current code.

xCausxn@8e8f411

[CosminPerRam]

Hey, I reviewed this again and I ended up doing what I mentioned in my first reply.
I don't think .trim is needed at the end, I queried a bunch of random servers to make sure stuff looks alright, have you found one that has at the end a bunch of whitespaces that shouldn't be there?

[joshhsoj1902]

Something about this change appears to not work as expected.

I use gamedig as part of some automated tests to confirm that gameservers start properly. Currently I've been using the "Name" field to test against.

It has started duplicating the server name in the name field (the name should just be "LinuxGSM"):

{"name":"LinuxGSMLinuxGSM","map":"","password":false,"raw":{"vanilla":{"name":"","map":"","password":false,"raw":{"version":{"name":"Paper 1.20.2","protocol":764},"enforcesSecureChat":true,"description":{"text":"LinuxGSM"},"players":{"max":20,"online":0},"bcc":{}},"version":"","maxplayers":20,"numplayers":0,"players":[],"bots":[],"queryPort":25565,"connect":"172.30.0.1:25565","ping":4}},"version":"Paper 1.20.2","maxplayers":20,"numplayers":0,"players":[],"bots":[],"queryPort":25565,"connect":"172.30.0.1:25565","ping":4}

I'll likely refactor my tests so that the server name doesn't matter, but I thought I would let you know just in case this is unintended.