Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: extract dayz from valve #448

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Conversation

CosminPerRam
Copy link
Member

@CosminPerRam CosminPerRam commented Jan 2, 2024

DayZ runs on Valve A2S but it is modified quite a bit and their data types needs to be read differently than standard ones, this PR extracts everything dayz related into another protocol file (which still runs on top of the valve protocol file), clears up a lot the cluttered Valve protocol file.

@CosminPerRam
Copy link
Member Author

CosminPerRam commented Jan 2, 2024

image
Responses are as expected, and now it is also possible to extract only the 'pure' valve response out of it as the game query implementation is completely compatible to 'vanilla' A2S.

@CosminPerRam
Copy link
Member Author

CosminPerRam commented Jan 2, 2024

another possible thing to do would be to still detect DayZ in the Valve protocol (via its app id) and instead of returning the valve response, run the dayz protocol, but I dont really know a reason to do this, better yet as said in my previous comment, its now possible to get the valve-only response with no dayz data addons, if you want the addons, run the DayZ protocol (this is default behaviour).

@CosminPerRam CosminPerRam merged commit 90b3c60 into master Jan 2, 2024
6 checks passed
@podrivo
Copy link
Contributor

podrivo commented Jan 4, 2024

This is incredible @CosminPerRam! Thank you! 🙌 🚀

@podrivo
Copy link
Contributor

podrivo commented Jan 4, 2024

I was wondering, will this be part of the version 4.3.2? I'm particularly interested in this commit (90e26bb), which I think is also related to this issue (#440).

@CosminPerRam
Copy link
Member Author

That specific commit no, that's changed behaviour regarding how players (or bots) are added into the list and that's a breaking change, so its for 5.X

@CosminPerRam CosminPerRam deleted the chore/extract_dayz_valve branch January 18, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants