feat: update redorchestra to use correct query port and type #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove unused gamespy query - Merged redorchestra and ro4145 - Corrected gameport - Set to Unreal2 protocol
CosminPerRam
requested changes
Sep 27, 2024
lib/games.js
Outdated
| protocol: 'unreal2' | ||
| } | ||
| }, | ||
| roo4145: { |
There was a problem hiding this comment.
The GID for the game name should be roo4145, not redorchestra.
lib/games.js
Outdated
Comment on lines
2382
to
2383
| extra: { | ||
| old_id: 'redorchestraost' |
There was a problem hiding this comment.
We can't remove the old id as it breaks backwards compatibility.
lib/games.js
Outdated
Comment on lines
2366
to
2373
| name: 'Red Orchestra', | ||
| release_year: 2018, | ||
| options: { | ||
| port: 7758, | ||
| port_query_offset: 1, | ||
| protocol: 'unreal2' | ||
| } | ||
| }, |
There was a problem hiding this comment.
We can't remove this entry, even if it is completely wrong and if it is, we should remove it in a major version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors Red Orchestra
Partly fixes #616