fix: remove another instance of adding empty player objects valve

Related: #389
gamedig · Dec 25, 2023 · 90e26bb · 90e26bb
1 parent dcc69a3
commit 90e26bb
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/protocols/valve.js b/protocols/valve.js
@@ -427,13 +427,12 @@ export default class valve extends Core {
     })
     delete state.raw.players
     const numBots = state.raw.numbots || 0
-    while (state.bots.length < numBots) {
-      if (sortedPlayers.length) state.bots.push(sortedPlayers.pop())
-      else state.bots.push({})
+
+    while (state.bots.length < numBots && sortedPlayers.length) {
+      state.bots.push(sortedPlayers.pop())
     }
-    while (state.players.length < state.numplayers - numBots || sortedPlayers.length) {
-      if (sortedPlayers.length) state.players.push(sortedPlayers.pop())
-      else state.players.push({})
+    while ((state.players.length < state.numplayers - numBots || sortedPlayers.length) && sortedPlayers.length) {
+      state.players.push(sortedPlayers.pop())
     }
   }