Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add catchall OSError to recoverable exceptions #338

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Add catchall OSError to recoverable exceptions #338

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pulsar/client/amqp_exchange.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,9 @@ def __init__(
ConnectionResetError, # https://github.com/galaxyproject/pulsar/issues/328
TimeoutError,
socket.timeout,
# Needed as long as py-ampq raises plain OSError:
# https://github.com/celery/py-amqp/blob/a92dd037712b5b7b1622f4f9d83157d095c90910/amqp/transport.py#L584
OSError,
amqp.exceptions.ConnectionForced, # e.g. connection closed on rabbitmq sigterm
amqp.exceptions.RecoverableConnectionError, # connection closed
amqp.exceptions.RecoverableChannelError, # publish time out
Expand Down