avoid using getcwd() in cli module pattern matching #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this did not work in most of the cases due to the getcwd() call.
mvdbeek
reviewed
Aug 10, 2021
| @@ -24,7 +24,7 @@ def __init__(self, code_dir='lib'): | |||
| """ | |||
| """ | |||
| def __load(module_path, d): | |||
| module_pattern = join(join(getcwd(), code_dir, *module_path.split('.')), '*.py') | |||
| module_pattern = join(join(dirname(__file__), module_path.split('.')[-1]), '*.py') | |||
There was a problem hiding this comment.
I think the implementation of the pulsar variant and the Galaxy variant have diverged.
I think you could copy https://github.com/galaxyproject/galaxy/blob/dev/lib/galaxy/jobs/runners/util/cli/__init__.py over and that should fix it too ? In either case we should unify these two before we diverge further.
Might even be worth to delete the Galaxy variant and only keep the pulsar code.
There was a problem hiding this comment.
related galaxyproject/galaxy#10189
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this did not work in most of the cases due to the getcwd() call.